Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version. #50

Closed
wants to merge 1 commit into from
Closed

Bumped version. #50

wants to merge 1 commit into from

Conversation

homeworkprod
Copy link

Release 1.7.3 already mistakingly reports itself as version 1.7.2, so I thought I'd chime in and bump the version number before it gets overlooked again (especially with the "optoins" typo bug in 1.7.3, the currently latest release, I also instantly stumbled upon).

Release 1.7.3 already mistakingly reports itself as version 1.7.2, so I thought I'd chime in and bump the version number before it gets overlooked again (especially with the "optoins" typo bug in 1.7.3, the currently latest release, I also instantly stumbled upon).
@lurch
Copy link

lurch commented Oct 30, 2015

Duplicate of #56 ?

@homeworkprod
Copy link
Author

@lurch I'd say #56 is a duplicate of this one :)

@lurch
Copy link

lurch commented Oct 30, 2015

I only suggested #56 because that's the PR that has actually been merged ;-)
(i.e. this PR #50 could probably be closed/rejected?)

EDIT: Ah, I now see that #56 only bumps the version to 1.7.3, whereas this PR bumps the version to 1.7.4 - my apologies.

@homeworkprod
Copy link
Author

Right, my proposed change bumps the version to a new, unoccupied number (implicitly suggesting a new release) instead of trying to modify the already spread release (thus avoiding the tag issue mentioned in #56 altogether), which is something I consider quite pointless (from my own experience as well).

That said, I was referring to my PR being older than the other one. Not sure why mine wasn't accepted/merged; I think I'll include "fix" in future titles ;)

@jeffkaufman
Copy link
Owner

Sorry about the versioning mess. 1.7.6 went out today with version numbers cleared up and a small change, and version 1.7.7 should go out later today with a few more minor fixes.

@jeffkaufman jeffkaufman closed this May 2, 2016
@homeworkprod homeworkprod deleted the patch-1 branch May 3, 2016 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants