Add .asCase to VariantLens #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
requested review from
paul-a-kennedy-rally,
rajatkumar-agarwal,
darmbrus,
indra-rosadi-rally,
mlinenweber,
panpan666 and
vinit-garg
vinit-garg
approved these changes
Feb 5, 2022
jeffmay
commented
Feb 5, 2022
Comment on lines
+153
to
+157
| /** | ||
| * Attempt to cast the value of super-type [[B]] as sub-type [[V]] (if possible), otherwise None. | ||
| */ | ||
| def asCase[V <: B : Typeable]: VariantLens[A, Option[V]] = | ||
| lens.copy(get = lens.get.andThen(Typeable[V].cast)) |
There was a problem hiding this comment.
I think I should handle multiple cases at once, otherwise, you would be required to use when / then / else and unify the results. A Expr.Match might be a better option... it could also potentially replace the When operator as a more generally useful operator, but each branch has a lens that is applied before any optional condition guard.
mlinenweber
approved these changes
Feb 8, 2022
preetbawa
approved these changes
Feb 10, 2022
|
Closing in favor of #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.asCasetoVariantLensusingshapeless.Typeable