Add support for Expr.Match #95

jeffmay · 2022-02-17T03:03:43Z

Add support for guard expressions
Use existential types for case expressions
Add unit tests

core-v1/src/main/scala/algebra/Expr.scala

jeffmay · 2022-02-17T03:05:50Z

core-v1/src/main/scala/dsl/WrapSelected.scala

@@ -30,7 +30,6 @@ trait WrapSelected[W[+_], OP[_]] {
    path: DataPath,
    element: O,
  )(implicit
-    opA: OP[I],


This never really made sense... OP stands for "output parameter" and this is being applied to the input.

core-v1/src/main/scala/debug/DebugArgs.scala

core-v1/src/main/scala/algebra/Expr.scala

- Add support for guard expressions - Use existential types for MatchCase - Add unit tests - Add branch index to DebugArgs - Add more tests and separate sequence tests - Add evidence of subtyping to Match visitor method

codecov · 2022-02-18T21:20:26Z

Codecov Report

Merging #95 (f1a248e) into v1 (b06201a) will increase coverage by 1.05%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##               v1      #95      +/-   ##
==========================================
+ Coverage   60.38%   61.44%   +1.05%     
==========================================
  Files          93       93              
  Lines        1949     1987      +38     
  Branches       18       21       +3     
==========================================
+ Hits         1177     1221      +44     
+ Misses        772      766       -6

Impacted Files	Coverage Δ
core-v1/src/main/scala/data/Justified.scala	`83.01% <ø> (ø)`
core-v1/src/main/scala/dsl/BuildExprDsl.scala	`77.77% <ø> (ø)`
core-v1/src/main/scala/dsl/WrapSelected.scala	`100.00% <ø> (ø)`
...src/main/scala/engine/ImmutableCachingEngine.scala	`89.83% <0.00%> (-1.97%)`	⬇️
core-v1/src/main/scala/engine/StandardEngine.scala	`75.71% <0.00%> (-0.55%)`	⬇️
core-v1/src/main/scala/algebra/Expr.scala	`44.33% <60.00%> (+0.77%)`	⬆️
core-v1/src/main/scala/debug/DebugArgs.scala	`97.61% <100.00%> (+0.05%)`	⬆️
...-v1/src/main/scala/dsl/UnwrappedBuildExprDsl.scala	`89.87% <100.00%> (+0.68%)`	⬆️
...re-v1/src/main/scala/dsl/WrappedBuildExprDsl.scala	`78.57% <100.00%> (+3.57%)`	⬆️
core-v1/src/main/scala/engine/SimpleEngine.scala	`40.00% <100.00%> (+15.21%)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06201a...f1a248e. Read the comment docs.

core-v1/src/main/scala/algebra/Expr.scala

core-v1/src/test/scala/SimpleJustifiedMatchSpec.scala

paul-a-kennedy-rally

LGTM

jeffmay mentioned this pull request Feb 17, 2022

Add .asCase to VariantLens #93

Closed