-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Marpa::R2::ASF::rh_values() and Marpa::R2::Scanless::R::rule_closure() methods and tests for them #93
add Marpa::R2::ASF::rh_values() and Marpa::R2::Scanless::R::rule_closure() methods and tests for them #93
Conversation
Looks llike a good idea. I'll look it over more closely during the next inter-phase. And you are right that |
Update: but we still need to test |
This reverts commit fa65e7c.
This is suggested like a solution for this issue #78 — Deyan was informed on IRC and will look into it as time permits — http://irclog.perlgeek.de/marpa/2014-01-23#i_8163300. |
rh_values() and rule_closure() are both done, tested in sl_panda1.t and thus ready for review. @deyan provided an example and I added the code to show how they work -- http://gist.github.com/rns/8579375 |
Great! I'll get to work on this, probably tomorrow California time. |
Merge branch 'add_rh_values_to_ASF' of github.com:rns/Marpa--R2 into rns-add_rh_values_to_ASF
I have a couple of follow-up issues, but Github auto-closed this when I merged and re-opening is not allowed. So I've moved the discussion to issue #78 |
rh_values()
is a shortcut foras used in
sl_panda.t
.Also, if I got Deyan's idea right, it could be useful for
rule_closure()
:which I plan to test in
sl_panda1.t
.If that's what's been meant, I can start writing
rule_closure()
to convert allto
$panda_recce
is here for a reason because I thinkrule_closure()
needs to be a method ofScanless::R
, notScanless::G
because actions are resolved inScanless::R
andrule_closure()
must return resolved actions.