Skip to content

Commit

Permalink
Disabled incremental build since it isn't working
Browse files Browse the repository at this point in the history
// Incremental builds through changedInPlace are not working like I had
naively hoped they would.  I believe now
// that what I need is a (1) background task running which watches for
file updates and updates a dirtyCache with
// them, and (2) in transpilation tasks check the stream's set of files
against that cache and only pass them
// through if they are in there (and then remove them from the cache
once done).  HOWEVER, VS Code doesn't currently
// support that; microsoft/vscode#981.  So:
leaving in place in case I'm just missing
// something obvious, but disabling since it isn't working.
  • Loading branch information
Jeff Simon committed Dec 11, 2016
1 parent 1f47754 commit 6a7c9f3
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -536,5 +536,14 @@ gulp.task("rebuild-all-duality", function () {

// Builds duality
gulp.task("build-duality", function () {

// Incremental builds through changedInPlace are not working like I had naively hoped they would. I believe now
// that what I need is a (1) background task running which watches for file updates and updates a dirtyCache with
// them, and (2) in transpilation tasks check the stream's set of files against that cache and only pass them
// through if they are in there (and then remove them from the cache once done). HOWEVER, VS Code doesn't currently
// support that; https://github.com/Microsoft/vscode/issues/981. So: leaving in place in case I'm just missing
// something obvious, but disabling since it isn't working.
settings.incrementalBuild = false;

return buildDuality();
});

0 comments on commit 6a7c9f3

Please sign in to comment.