Check insert optimization for bank_forks (solana-labs#24641)

* check insert optimization * clippy suggested simplification
jeffwashington · Jun 29, 2022 · d408995 · d408995
1 parent c6be480
commit d408995
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/runtime/src/bank_forks.rs b/runtime/src/bank_forks.rs
@@ -131,11 +131,10 @@ impl BankForks {
             banks.insert(bank.slot(), bank.clone());
             let parents = bank.parents();
             for parent in parents {
-                if banks.contains_key(&parent.slot()) {
+                if banks.insert(parent.slot(), parent.clone()).is_some() {
                     // All ancestors have already been inserted by another fork
                     break;
                 }
-                banks.insert(parent.slot(), parent.clone());
             }
         }
         let mut descendants = HashMap::<_, HashSet<_>>::new();