Check insert optimization for bank_forks #24641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
carllin
approved these changes
Apr 25, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 27, 2022
* check insert optimization * clippy suggested simplification
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* check insert optimization * clippy suggested simplification
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* check insert optimization * clippy suggested simplification
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* check insert optimization * clippy suggested simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When inserting parent into bank_forks, we perform a check for existence then do the actual insert. This can be optimized by do the insert first, then check that if return is None. Thus, it saves one lookup of the parents.
Summary of Changes
Do the insert first, then check the return value.
Fixes #