Add CI support for Sprockets 4 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jejacks0n Any chance for a new release soon to support apps upgrading to Sprockets 4? Thanks! |
rossta
force-pushed
the
task/add-appraisals
branch
2 times, most recently
from
4b7ca0a
to
74c6b2f
Compare
|
I just open rails/sprockets#650 because I tried to move to Sprocket 4. Hope this helps. |
|
This might help: I had the same error when I upgraded my Rails app with teaspoon to Sprockets 4 and fixed the issue by pointing to teaspoon master: gem 'teaspoon-jasmine', github: "jejacks0n/teaspoon" I use jasmine but it would be similar for teaspoon-qunit or teaspoon-mocha. |
gemfiles/rails_6_sprockets_3.gemfile
Outdated
| gem "teaspoon-qunit", path: "../teaspoon-qunit" | ||
| gem "rubocop", require: false | ||
| gem "rubocop-rails_config" | ||
| gem "sprockets", "< 4" |
There was a problem hiding this comment.
this file is now a duplicate of the other rails 6 above...
| gem "teaspoon-jasmine", path: "../teaspoon-jasmine" | ||
| gem "teaspoon-mocha", path: "../teaspoon-mocha" | ||
| gem "teaspoon-qunit", path: "../teaspoon-qunit" | ||
| gem "rubocop", require: false | ||
| gem "rubocop-rails_config" | ||
| gem "sprockets", "< 4" |
There was a problem hiding this comment.
we already have rails6+sprockets3 file
mathieujobin
approved these changes
Apr 21, 2020
|
please rebase and remove the duplicate files squash into 1 commit |
Add CI support for Sprockets 4 Additional Appraisal gemfiles are added to test against combinations of Rails 5 or Rails 6 with Sprockets 3 or 4. Also bumps Rails 5 and Rails 6 appraisals Configure travis to use xvfb service For more info: https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-services-xvfb
rossta
force-pushed
the
task/add-appraisals
branch
from
74c6b2f
to
b8db61f
Compare
|
Better late than never? This PR is now rebased against the default branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Appraisal gemfiles are added to test against combinations of Rails 5 or Rails 6 with Sprockets 3 or 4. Also bumps Rails 5 and Rails 6 appraisals.
Thanks for maintaining this very useful gem!