Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark refactoring, improving efficiency, enhanced reporting #107

Merged
merged 4 commits into from
Jan 11, 2017
Merged

Benchmark refactoring, improving efficiency, enhanced reporting #107

merged 4 commits into from
Jan 11, 2017

Conversation

ibnesayeed
Copy link
Contributor

  • Refactored benchmark code to reduce the number of reads of the data file
  • Added SpecReporter that shows each test case name grouped with suit names instead of the default progress bar that was not very informative
  • Added custom reporter for benchmarks to better represent the information in a copy paste friendly format -- bye bye NOPROGRESS ENV hack
  • Added record counts on which benchmarks were performed

ibnesayeed referenced this pull request Jan 9, 2017
@ibnesayeed @Ch4s3
Added Bayes backend benchmarks (#98)
e21a9be 
* Disabled Redis disc persistence and refactored integration test, fixes #95

* Added Bayes backend benchmarks
@Ch4s3
Copy link
Member

Ch4s3 commented Jan 9, 2017

I'll take a look later today, thanks!

@ibnesayeed
Copy link
Contributor Author

@Ch4s3: I'll take a look later today, thanks!

I am making some changes here to better organize the code.

@ibnesayeed
Copy link
Contributor Author

@Ch4s3, I think I am done refactoring for now. Please go ahead for code review and merging if seems good.

ibnesayeed
ibnesayeed commented Jan 10, 2017
View reviewed changes
test/bayes/bayesian_common_benchmarks.rb

class BenchmarkReporter < Minitest::Reporters::RubyMateReporter
def before_suite(suite)
puts ([suite] + BayesianCommonBenchmarks.bench_range).join("\t")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have much preferred to extract this custom reporter into a separate file and potentially share that with other benchmarks in future, but the kind of data I am using in the before_suite method will not be available outside, unless there is a way that I am unaware of.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine

@Ch4s3 Ch4s3 merged commit 97de219 into jekyll:master Jan 11, 2017
@ibnesayeed ibnesayeed deleted the reporting branch January 11, 2017 03:12
@ibnesayeed ibnesayeed mentioned this pull request Jan 11, 2017
Merged
Ch4s3 pushed a commit that referenced this pull request Jan 11, 2017
@ibnesayeed @Ch4s3
Remove residue after refactoring #107 (#111)
ad24303
Ch4s3 pushed a commit that referenced this pull request Jan 11, 2017
@ibnesayeed @Ch4s3
Speed up Docker image rebilding (#112)
e9622cc 
* Remove residue after refactoring #107

* Speed up Docker image rebilding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch4s3 Ch4s3 Ch4s3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibnesayeed @Ch4s3