Remove mathn dependency #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how we could confirm this... Mathn adds lots of monkeypatches, right? So it could affect any number of operations it touches. We could just wing it and if it breaks in our Jekyll tests then we know it should be revisited? |
|
@parkr Haha sure. We could also rely on any bug reports that come in. It'll be pretty easy to tell since they would all be math errors. |
parkr
added a commit
that referenced
this pull request
Aug 13, 2014
parkr
added a commit
that referenced
this pull request
Aug 13, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mathn dependency. Seems that only a single area required changes after the removal of mathn to pass the tests, but we probably need to confirm this. Any ideas?