Bump Jekyll to v2.3.0

[parkr]

https://github.com/jekyll/jekyll/releases/tag/v2.3.0
jekyll/jekyll@v2.2.0...v2.3.0

@benbalter, this should solve some support tickets.

[bcomnes]

👍

[chibicode]

Waiting for this so that liquid filters work on Sass! Thanks @benbalter

[gjtorikian]

I also need this for more movement on the Help project 😀 https://twitter.com/parkr/status/502539498710790144

Should be safe to bump and deploy? Or are we asking for security releases for minor bumps these days?

/cc @github/pages
/cc @mastahyeti (let me know if you don't want to be directly pinged on this, not sure if github/dotcom-security is appropriate)

[gjtorikian]

This also fixes #87.

[kansaichris]

This also fixes #87.

@gjtorikian I think you may have pasted the wrong link?

[gjtorikian]

I N F I N I T E L O O P

This also fixed #85.

[chibicode]

Saw that the gem version is now 23 but Jekyll itself wasn't updated - any ETA on this? 7081674

[parkr]

I believe we're waiting to hear back from GitHub's Security team on this one, but not sure the internal status of it.

As always, it'll be taken care of 🔜! 😄

[benbalter]

@parkr @mention'd you on two of the included PRs with a few questions on the security front from my own review.

[parkr]

@benbalter Will make sure to address them all today. Thank you!

[stephenmcd]

Sorry to bump but any word on this? Site's been broken for weeks.

[kleinfreund]

@stephenmcd Why is your site broken? Have you pushed a Jekyll site running 2.3.0 to GitHub while using Pages? Well, this won't obviously work currently.

[stephenmcd]

See #85

[jdennes]

Site's been broken for weeks.

You should always be running/testing your site locally using the github-pages gem, as per these instructions if you expect to publish it to GitHub Pages.

[stephenmcd]

@jdennes sure, no arguing there. Doesn't change the fact a broken version of jekyll has been deployed for weeks :-)

[chibicode]

Just a reminder: when this goes out, this commit should be reverted :) jekyll/jekyll@069805c

[btoews]

What is with the collection/collection-reborn switch?

[parkr]

What is with the collection/collection-reborn switch?

Hey @mastahyeti! We noticed a bug with classifier that caused HTML to be rendered totally strangely by every single markdown renderer (jekyll/jekyll#2676) and caused many numbers to be instance of Rational which ruined division (jekyll/jekyll#2702). As classifier seemed not to be moving forward, I figured I'd fork it (jekyll/classifier-reborn) and fix the issues. The key was the inclusion of the mathn library, which did strange thing to maths. We removed it in classifier-reborn (jekyll/classifier-reborn#8) and used classifier-reborn in Jekyll (jekyll/jekyll#2721). So far, we've released v2.0.0 and v2.0.1 (releases contain all changes via links to PR's).

[btoews]

I'm a bit confused by the changes in jekyll/jekyll@v2.2.0...v2.3.0#diff-88ebc99d4a7c9f72a3e30a91bebf8ea8R28. I thought you added SASS in the 2.0 bump. What is this change doing?

[btoews]

Assuming the SASS/SCSS thing isn't really adding any functionality, I think this diff looks okay.

[ksweetie]

@mastahyeti sassify and scssify let you manually convert sass/scss. Here's the original PR with an explanation of why this is useful:

jekyll/jekyll#2739

[btoews]

Ah, cool. Yeah, this PR seems fine then.

[chibicode]

👍

[benbalter]

Thanks @parkr, @mastahyeti and all others who weighed in. Looking forward to getting a new version of the gem out shortly.

[parkr]

Thanks, @benbalter!!