-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use localhost:4000 as the default pages host in development #50
Conversation
@benbalter I thought |
Explained my understanding in #49 (comment). Would love to hear your thoughts there, as I suspect the two discussions are really one. |
@@ -33,21 +33,38 @@ | |||
end | |||
end | |||
|
|||
it "picks up on JEKYLL_ENV" do | |||
with_env "PAGES_ENV", "" do | |||
with_env("JEKYLL_ENV", "halp") do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent parentheses please 😄
@parkr now that tests pass, how does this look to you? |
|
||
def custom_domains_enabled? | ||
dotcom? || test? | ||
end | ||
|
||
def env | ||
env_var 'PAGES_ENV' | ||
env_var 'PAGES_ENV', ENV['JEKYLL_ENV'] | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still feeling dubious about this but 🤷
LGTM |
LGTM. |
@jekyllbot: merge +major |
Fixes #47.