Add MetadataDrop#to_s which outputs pretty JSON representation #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
approved these changes
Oct 11, 2016
| expect(payload["site"]["github"]).to be_instance_of(described_class) | ||
| template = Liquid::Template.parse("{{ site.github }}") | ||
| result = template.render!(payload, :registers => { :site => site }) | ||
| expect(result).to eql(subject.to_s) |
There was a problem hiding this comment.
Aren't you just testing that Liquid calls to_s on this? Wouldn't this be true if the to_s method wasn't defined? Perhaps match a regex on the content?
There was a problem hiding this comment.
Good point. Updated to match the JSON.pretty_generate.
benbalter
approved these changes
Oct 13, 2016
parkr
added a commit
that referenced
this pull request
Oct 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
{{ site.github }}doesn't expand out to all the values in the Drop.This is controlled by
Drop#to_swhich, by default, isself.class.name./cc @jekyll/gh-pages