Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting Jekyll Admin's front-end from scratch 🎉 #437

Closed
mertkahyaoglu opened this issue Nov 29, 2017 · 8 comments
Closed

Rewriting Jekyll Admin's front-end from scratch 🎉 #437

mertkahyaoglu opened this issue Nov 29, 2017 · 8 comments
Assignees

Comments

@mertkahyaoglu
Copy link
Member

mertkahyaoglu commented Nov 29, 2017

Looking at the codes I have written in the past makes me feel ashamed of myself 😁 There is so much boilerplate that a person need to add in order to implement a feature and the codebase is very hard to understand right now. I think this is what keeps people away from contributing to the project. So I decided to rewrite Jekyll Admin from scratch and already started working on it. I'm using Ant Design for UI components. It has dozens of reusable components which will allow us integrate any component with a little modification easily without implementing our own. In addition it will reduce the codebase a lot since we will not be having custom components and their tests anymore. Maintaining the project will be a lot easier. Another gain of Ant Design is that we don't have to thing about design anymore. We can follow its design guide.

The most important part is I'm changing the infrastructure and adding some great libraries from the community which will solve our problems very easily. I decided to use redux-form for managing forms in general, react-intl for translations (it's time to have this since we have lots of languages already translated), api-sauce to talk to the API in a more robust way and so many other things that I have in mind.

I'm planning to release the new version at the end of the year (being very optimistic 😁). Hopefully manage to find enough time to achieve this. Until then I won't be fixing the current bugs or introduce new features. My main goal is while doing this, I need to cover all of the current features and solve as much issues as possible we have now. Very exciting about this. See you guys when this is released ✋

@mertkahyaoglu mertkahyaoglu changed the title Rewriting Jekyll Admin's front-end from scratch 🎉 Rewriting Jekyll Admin's front-end from scratch 🎉 Nov 29, 2017
@mertkahyaoglu mertkahyaoglu self-assigned this Nov 29, 2017
@matbrgz
Copy link

matbrgz commented Dec 14, 2017

Ant is too much verbose, no? Why not keep things simple with Semantic UI?

Is anything I could do to help? I'm good UI designer.

@mertkahyaoglu
Copy link
Member Author

@MatheusRV Yeah, but we use only what we need, other things will not be in the production bundle.
Thanks for asking. Your help is really appreciated after the release. For now, the main focus is to release fast without getting into design.

@mslinn
Copy link

mslinn commented Jan 4, 2018

It would be great to have a visual editor. I have done this myself two ways on different projects.

  1. Create a custom design and implementation. Here is a video I made that shows a tweet stream editor. Three properties of an HTML form can be edited live (content is continually rendered): tweet text, link url and image url.

  2. Use a package like CKEditor for editing posts. I have integrated CKEditor into another project and the experience was terrific all around.

Regardless of how it is implemented, the visual editor should allow users to edit headers and their fields. Here is an example of the fields I am thinking of:

---
layout: post
title: My Title
category: MyCategory
---

The main portion of the posting would be displayed and editable in whatever types of CKEditor editors you folks decide to implement.

@phillipesouza
Copy link

There is the Toast Editor, its a visual MD editor, good for people that don't know MD.

Where do I find the code of this new version?

@mertkahyaoglu
Copy link
Member Author

@phillipesouza You can find the code on theme-v2 branch.

@phillipesouza
Copy link

@mertkahyaoglu Thanks!

@jekyllbot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@mslinn
Copy link

mslinn commented Mar 14, 2020

Too bad this issue got closed. Most users would find this feature useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants