Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hiding sidebar links #361

Merged
merged 7 commits into from
May 11, 2017
Merged

Support hiding sidebar links #361

merged 7 commits into from
May 11, 2017

Conversation

mertkahyaoglu
Copy link
Member

Fixes #353

This PR adds a feature that allows users to hide sidebar links. You can specify the links that you don't want in the sidebar by adding hidden_links to _config.yml.

Example;

hidden_links:
  - posts
  - pages
  - ..

@ashmaroli
Copy link
Member

ashmaroli commented May 4, 2017

Nice.. lots of changes.
Couple of suggestions:

  • Since the single commit related to this PR was written after series of merge commits, use can have the merge commits removed from here by rebasing to origin/master.
# set ENV to your time of authoring commit (e.g.) 
$ GIT_COMMITTER_DATE="May 03 2017 22:24:30" git rebase origin/master
  • can we have the config settings under a jekyll-admin namespace?
# _config.yml

jekyll-admin:
  hidden_links:
    - posts
    - pages
    - ..

@ashmaroli
Copy link
Member

I see a couple of errors in the browser console when I start up server-frontend Our test suites don't cover these lines because of the shallow wrappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants