-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GUI support to DataFileNew #362
Conversation
- separate elements for basename and extension - normalize file extensions: all data files created via the GUI will either have `.yml` or `.json` extension
There is one issue I encountered. When you change a field type in the gui mode, for example making it list, |
src/containers/views/DataFileNew.js
Outdated
// Prevent the default event from bubbling | ||
preventDefault(e); | ||
|
||
let filename; | ||
if (datafileChanged) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about fieldChanged
? Save action won't be dispatched if users directly edit in the gui mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its an interface for Create
. Enter the path in InputPath
and viola!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you fix the below bug, you will face this one 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create button is active but clicking it won't create anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're not sending a data object to the put
action via the GUI, so this shouldn't matter..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I can't create the datafile 😄 I'm copy-pasting steps below;
- Click New Data File
- Switch to GUI mode.
- Enter filename as test
- Select extension
- Change first field type to list
- Add some array items.
- Try to
Create
datafile. - Nothing happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgive my nearsightedness, Master.. 🙏
pushed a patch..
No, that was intentional.. The |
Could you try the following steps;
|
Uh-oh.. didn't expect that bug.. |
I've made a minor change in the save button behavior: It'll get |
Awesome 👍 Thanks @ashmaroli . |
DataFileNew
Either listen toInputPath
value and disablecreateButton
,select
the file extension.