Tag static files from a theme-gem with a sticker #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertkahyaoglu
requested changes
Jun 23, 2017
src/components/FilePreview.js
Outdated
| @@ -32,9 +32,18 @@ export default class FilePreview extends Component { | |||
| } | |||
| return ( | |||
| <div className="file-preview"> | |||
| { | |||
There was a problem hiding this comment.
I know I've put a few inline conditions in the front-end but it's better to pull them out of return statement which makes it more readable.
let theme_indicator;
let btn_delete;
if(file.from_theme) {
theme_indicator = <div...
} else {
btn_delete = <button...
}
src/components/FilePreview.js
Outdated
| <button onClick={() => this.handleClickDelete(file.path)} className="delete" title="Delete file">x</button> | ||
| { | ||
| !file.from_theme && | ||
| <button onClick={() => this.handleClickDelete(file.path)} className="delete" title="Delete file">x</button> |
There was a problem hiding this comment.
Why should we not allow deleting theme files?
There was a problem hiding this comment.
Why should we not allow deleting theme files?
While I was greatly surprised that you asked this question, on reflecting further, I'm assuming you were talking about removing the Jekyll::StaticFile object from the site_payload rather than deleting the file proper..
To answer otherwise, three things to consider:
- The theme-gem is supposed to be a read-only object for Jekyll.
- We have no write-access outside
site.source. - When users click
delete, on a theme-file they're sending adeleterequest to therelative_pathof the static file which is sanitized to point to a non-existing entity in thesource_dir. (e.g.<theme>/assets/logo.pngwill resolve as<site.source>/assets/logo.pngwhich doesn't exist. Otherwise, Jekyll would've read that file in to memory instead)
There's no valid use-case to allow write-access to the theme-gem in future either
mertkahyaoglu
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to easily distinguish which static-file displayed in
Dropzoneis from thesite.sourceand which one is from the theme-gem.Additionally, there's no sense that users can click delete on a static-file from the theme-gem.
This PR resolves both of above.
