Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose data file's basename as attribute name #512

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

ashmaroli
Copy link
Member

This is to provide JekyllAdmin::DataFile instances parity with primitives from Jekyll.

Jekyll::Page, Jekyll::Document, Jekyll::StaticFile instances exposes their basename with extension via Liquid and therefore the API here as either :name or :basename

Copy link
Member

@mertkahyaoglu mertkahyaoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. We can use this in the front-end now 👍

@ashmaroli
Copy link
Member Author

We can use this in the front-end now

Yep. That's the idea.. 😃

@mertkahyaoglu
Copy link
Member

Don't know why we didn't have this at the beginning 🤔

@ashmaroli
Copy link
Member Author

Don't know why we didn't have this at the beginning

It was planned perhaps.. probably the reason why the private alias :filename was defined..
I've now removed that alias since it is just redundant..

@ashmaroli ashmaroli merged commit 7b6fc14 into jekyll:master Oct 11, 2019
@ashmaroli ashmaroli deleted the data-file-basename branch October 11, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants