Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept additional arguments in script/test-server #584

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

alzeih
Copy link
Contributor

@alzeih alzeih commented Mar 5, 2020

This allows for overriding defaults.

For example: ./script/test-server --host 127.0.0.1 --port 4000

Signed-off-by: alzeih alzeih@users.noreply.github.com

This allows for overriding defaults.

For example: `./script/test-server --host 127.0.0.1 --port 4000`

Signed-off-by: alzeih <alzeih@users.noreply.github.com>
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ashmaroli ashmaroli merged commit a77ef1d into jekyll:master Mar 5, 2020
@ashmaroli
Copy link
Member

I don't understand what's happening. GitHub is attributing the commits as authored by me.. This is wrong.. 😞

ashmaroli pushed a commit that referenced this pull request Mar 5, 2020
This allows for overriding defaults.

For example: `./script/test-server --host 127.0.0.1 --port 4000`

Signed-off-by: alzeih <alzeih@users.noreply.github.com>
@ashmaroli
Copy link
Member

Had to reset the master branch to assign correct attribution..

@alzeih alzeih deleted the patch-3 branch March 5, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants