Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet known warnings in tests #103

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Quiet known warnings in tests #103

merged 1 commit into from
Apr 14, 2016

Conversation

pathawks
Copy link
Member

Every time I test, I see

Randomized with seed 16380
............................Validation warning: Two entries with the same value for atom:updated on line 5 column 239
Validation warning: content should not be blank on line 5 column 898
Validation warning: summary should not be blank on line 5 column 917
.

Finished in 3.26 seconds (files took 0.884 seconds to load)
29 examples, 0 failures

These warnings are just noise. The content and summary warnings come from a test case that checks for blank content. The warning about duplicate atom:updated values is just because several files were added to the git repo at once.

I want to make sure that nothing we change accidentally introduces new warnings.

These expected warnings are just ignored, and so should not even appear in the test output.

@parkr parkr changed the title Quiet known warnings Quiet known warnings in tests Apr 14, 2016
@parkr
Copy link
Member

parkr commented Apr 14, 2016

❤️

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c386e66 into master Apr 14, 2016
@jekyllbot jekyllbot deleted the pr/quiet-warnings branch April 14, 2016 02:39
jekyllbot added a commit that referenced this pull request Apr 14, 2016
@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants