Fix Title extraction in Drupal 7 import script #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2015 12:22
This patch is designed to solve this Drupal 7 import bug: jekyll#90 where titles are dumped as ugly binary strings, and not UTF-8 strings.
parkr
added a commit
that referenced
this pull request
Mar 20, 2015
|
You're the bomb!! |
|
Thank you!! 🙏 |
|
You're very welcome. And thanks for merging the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in this Github Issue: Problem extracting titles from Drupal 7 site,
drupal7.rbdumps a binary mess in each post instead of the Title string.I have fixed this bug entirely by forcing the strings into Unicode format (and stripping any preceding and ending whitespace with
strip):That way, it works even for those pesky titles with stray \xE2 junk that screws everything up.
Please merge this pull request to fix the Drupal 7 importer. Try it out.