Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forced utf8 encoding of titles #22

Merged
merged 1 commit into from
Jun 30, 2013
Merged

Add forced utf8 encoding of titles #22

merged 1 commit into from
Jun 30, 2013

Conversation

chrisivens
Copy link
Contributor

Prevents yaml from binary encoding the title

@chrisivens
Add forced utf8 encoding of titles
a14665d 
Prevents yaml from binary encoding the title
@parkr
Copy link
Member

parkr commented May 11, 2013

I don't think 1.8.7 strings contain #force_encoding. Could you write a test for this?

@steko
Copy link

steko commented Jun 5, 2013

FWIW I can confirm that I have this issue with Ruby 1.9.3 and the proposed patch fixes the problem.

@parkr
Copy link
Member

parkr commented Jun 6, 2013

Shouldn't we encode() as utf-8 instead of force encode?

parkr added a commit that referenced this pull request Jun 30, 2013
@parkr
Merge pull request #22 from chrisivens/fix-drupal6-titles
2e1354f 
Add forced utf8 encoding of titles
@parkr parkr merged commit 2e1354f into jekyll:master Jun 30, 2013
parkr added a commit that referenced this pull request Jun 30, 2013
@parkr
Update history to reflect merge of #22.
afa912d
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisivens @parkr @steko @jekyllbot