New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forced utf8 encoding of titles #22

Merged
merged 1 commit into from Jun 30, 2013

Conversation

Projects
None yet
4 participants
@chrisivens
Contributor

chrisivens commented May 11, 2013

Prevents yaml from binary encoding the title

Add forced utf8 encoding of titles
Prevents yaml from binary encoding the title
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 11, 2013

Member

I don't think 1.8.7 strings contain #force_encoding. Could you write a test for this?

Member

parkr commented May 11, 2013

I don't think 1.8.7 strings contain #force_encoding. Could you write a test for this?

@steko

This comment has been minimized.

Show comment
Hide comment
@steko

steko Jun 5, 2013

FWIW I can confirm that I have this issue with Ruby 1.9.3 and the proposed patch fixes the problem.

steko commented Jun 5, 2013

FWIW I can confirm that I have this issue with Ruby 1.9.3 and the proposed patch fixes the problem.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 6, 2013

Member

Shouldn't we encode() as utf-8 instead of force encode?

Member

parkr commented Jun 6, 2013

Shouldn't we encode() as utf-8 instead of force encode?

parkr added a commit that referenced this pull request Jun 30, 2013

@parkr parkr merged commit 2e1354f into jekyll:master Jun 30, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jun 30, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.