Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Sass to load from theme-gem if possible #80

Merged
merged 5 commits into from Aug 4, 2019

Conversation

ashmaroli
Copy link
Member

Add _sass from within theme-gems to Sass.load_paths if the current site uses a theme gem and the theme-gem contains _sass directory at its root.

@DirtyF DirtyF requested a review from a team October 12, 2018 13:55
@DirtyF DirtyF requested a review from a team November 14, 2018 13:18
@DirtyF DirtyF added this to the v2.0 milestone Mar 24, 2019
@DirtyF DirtyF requested a review from mattr- May 9, 2019 10:18
@DirtyF
Copy link
Member

DirtyF commented May 9, 2019

@ashmaroli Can you please resolve the conflicts, I'd like us to ship a new release of this gem with sassc support.

@ashmaroli
Copy link
Member Author

@DirtyF I intentionally let this slide because I'm not sure if this is the right approach.. jekyll:master is still hard-coded to use the EOL Sass library when using theme-gems in a Jekyll build..

That said, as of now, the master branch of this project is not fully compatible with Jekyll builds on Windows (based on the latest AppVeyor results).

If you must release a new version of this plugin despite the above, go ahead. This PR can be shipped later..

@DirtyF
Copy link
Member

DirtyF commented Aug 4, 2019

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 0ad796c into jekyll:master Aug 4, 2019
jekyllbot added a commit that referenced this pull request Aug 4, 2019
@ashmaroli ashmaroli deleted the theme-support branch August 4, 2019 11:20
@jekyll jekyll locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants