Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags to JSON metadata #151

Merged
merged 37 commits into from Apr 6, 2017
Merged

Add tags to JSON metadata #151

Changes from 2 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f82ea47
Fix Google Structured Data Requests
aav7fl Jan 16, 2017
8d2febf
Fix typo. Oops.
aav7fl Jan 16, 2017
2ddab03
Fix word casing
aav7fl Jan 16, 2017
4868d22
Add the rest of the JSON tags to pass blogPosting Errors/Warnings
aav7fl Jan 17, 2017
30d4ffc
Fix language mistake
aav7fl Jan 17, 2017
a2a2c56
Add pull request documentation
aav7fl Jan 17, 2017
8cc9b2d
Add test for image object with dimensions
aav7fl Jan 18, 2017
9aa2cbf
Wite tests for implemented features.
aav7fl Jan 18, 2017
10d5f82
Travis doesn't like my timestamps for testing.
aav7fl Jan 18, 2017
b04f739
Match rubocop styling.
aav7fl Jan 18, 2017
fd5246a
Test output manually with Google Markup. Change inferred type. Improv…
aav7fl Jan 25, 2017
5437934
Implement PR #103 for my own use. Change template to better fit exist…
aav7fl Jan 25, 2017
644e976
Add test for PR #103
aav7fl Jan 25, 2017
a0f6588
Remove Author tag. I guess it really isn't used anymore.
aav7fl Jan 25, 2017
da498c7
Simplify documentation. Change to snake_case. Use Path instead of add…
aav7fl Jan 30, 2017
987e1ea
Merge branch 'master' into master
aav7fl Jan 30, 2017
6ebc866
Appease RuboCop
aav7fl Jan 30, 2017
cc02710
Merge branch 'master' into master
aav7fl Feb 15, 2017
8e36fe4
Update docs. Add use case. Add test.
aav7fl Feb 15, 2017
ba16b95
Propose new image handling method.
aav7fl Feb 16, 2017
a847a69
Fix small test case blunder.
aav7fl Feb 16, 2017
318de34
Remove unnecessary/confusing wording.
aav7fl Feb 16, 2017
4c577ff
Add legacy test and maintain old methods
aav7fl Feb 17, 2017
02eb926
Appease RuboCop
aav7fl Feb 17, 2017
3410fee
Merge branch 'master' into master
aav7fl Feb 22, 2017
c31f4c6
Better test coverage. Some overlap, but easier to understand. Some te…
aav7fl Feb 24, 2017
89aad3b
Merge pull request #1 from aav7fl/testing
aav7fl Feb 24, 2017
74c2d3d
Code deprecated note
aav7fl Feb 25, 2017
0b289b8
Merge branch 'master' into master
aav7fl Mar 3, 2017
e8e54a9
Merge branch 'master' into master
aav7fl Apr 3, 2017
48ba285
Image changes should be removed
aav7fl Apr 3, 2017
ac0886d
Merge branch 'master' into master
aav7fl Apr 3, 2017
bc32658
Clarify documentation
aav7fl Apr 3, 2017
6009b49
Separate tests.
aav7fl Apr 3, 2017
9ec685a
Merge branch 'master' into master
aav7fl Apr 4, 2017
61d4c91
Remove date default handle
aav7fl Apr 4, 2017
5b2e8f3
Merge branch 'master' into master
aav7fl Apr 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/template.html
View file
Open in desktop
Expand Up @@ -62,6 +62,9 @@
{% endif %}
{% endif %}
{% assign seo_author_twitter = seo_author_twitter | replace:"@","" %}
{% if seo_author.name %}
{% assign seo_author_name = seo_author.name %}
{% endif %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Author Name

{% endif %}

{% if page.seo and page.seo.type %}
Expand Down Expand Up @@ -206,6 +209,10 @@
"headline": {{ seo_page_title | jsonify }},
{% endif %}

{% if seo_author_name %}
"author": {{ seo_author_name | jsonify }},
{% endif %}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Author Name

{% if seo_page_image %}
"image": {{ seo_page_image | jsonify }},
{% endif %}
Expand All @@ -221,6 +228,9 @@
{% if seo_site_logo %}
"publisher": {
"@type": "Organization",
{% if seo_author_name %}
"Name": {{ seo_author_name | jsonify }},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It should. I'll change that shortly.

{% endif %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Author Name.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand Google's Structured Data Testing Tool requires publisher to be an Organization while Schema.org spec allows Person. So I have to ask, should publisher as an Organization be a person's name, or the site name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it depends how your website is created. A valid point.

"logo": {
"@type": "ImageObject",
"url": {{ seo_site_logo | jsonify }}
Expand Down