Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(template): use og:image for twitter #174

Merged
merged 1 commit into from Apr 3, 2017
Merged

refactor(template): use og:image for twitter #174

merged 1 commit into from Apr 3, 2017

Commits on Apr 3, 2017

  1. refactor(template): use og:image for twitter 

    #77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151. Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151.

Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
    Josh Habdas committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    e264a9a View commit details
    Browse the repository at this point in the history