Skip to content

Commit

Permalink
Delegated methods after private keyword are meant to be private (#6819
Browse files Browse the repository at this point in the history
)

Merge pull request 6819
  • Loading branch information
ashmaroli authored and jekyllbot committed Mar 8, 2018
1 parent c7f0076 commit 297371e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 10 deletions.
5 changes: 2 additions & 3 deletions lib/jekyll/drops/collection_drop.rb
Expand Up @@ -11,12 +11,11 @@ class CollectionDrop < Drop
def_delegators :@obj, :label, :docs, :files, :directory,
:relative_directory

private def_delegator :@obj, :metadata, :fallback_data

def to_s
docs.to_s
end

private
def_delegator :@obj, :metadata, :fallback_data
end
end
end
5 changes: 2 additions & 3 deletions lib/jekyll/drops/document_drop.rb
Expand Up @@ -14,6 +14,8 @@ class DocumentDrop < Drop
def_delegator :@obj, :relative_path, :path
def_delegators :@obj, :id, :output, :content, :to_s, :relative_path, :url

private def_delegator :@obj, :data, :fallback_data

def collection
@obj.collection.label
end
Expand Down Expand Up @@ -61,9 +63,6 @@ def collapse_document(doc)
result[key] = doc[key] unless NESTED_OBJECT_FIELD_BLACKLIST.include?(key)
end
end

private
def_delegator :@obj, :data, :fallback_data
end
end
end
5 changes: 2 additions & 3 deletions lib/jekyll/drops/site_drop.rb
Expand Up @@ -11,6 +11,8 @@ class SiteDrop < Drop
def_delegators :@obj, :time, :pages, :static_files, :documents,
:tags, :categories

private def_delegator :@obj, :config, :fallback_data

def [](key)
if @obj.collections.key?(key) && key != "posts"
@obj.collections[key].docs
Expand Down Expand Up @@ -49,9 +51,6 @@ def related_posts

# return nil for `{{ site.config }}` even if --config was passed via CLI
def config; end

private
def_delegator :@obj, :config, :fallback_data
end
end
end
3 changes: 2 additions & 1 deletion lib/jekyll/drops/static_file_drop.rb
Expand Up @@ -6,8 +6,9 @@ class StaticFileDrop < Drop
extend Forwardable
def_delegators :@obj, :name, :extname, :modified_time, :basename
def_delegator :@obj, :relative_path, :path
def_delegator :@obj, :data, :fallback_data
def_delegator :@obj, :type, :collection

private def_delegator :@obj, :data, :fallback_data
end
end
end

0 comments on commit 297371e

Please sign in to comment.