Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumbers tests need to be more clear around timezones #1126

Closed
jpiasetz opened this issue May 18, 2013 · 4 comments · Fixed by #1150
Closed

Cucumbers tests need to be more clear around timezones #1126

jpiasetz opened this issue May 18, 2013 · 4 comments · Fixed by #1150

Comments

@jpiasetz
Copy link
Contributor

The cucumbers tests need a clean up around time-zones. Some of the asserts are implicitly imply date times that would have different time-zones.

See #1090

@mattr-
Copy link
Member

mattr- commented May 23, 2013

Doesn't your pull request that I just merged fix this?

@jpiasetz
Copy link
Contributor Author

I meant this as a more generally then my pull request. For example:

  Scenario: Basic site with a post
    Given I have a _posts directory
    And I have the following post:
      | title   | date      | content          |   
      | Hackers | 3/27/2009 | My First Exploit |
    When I run jekyll
    Then the _site directory should exist
    And I should see "My First Exploit" in "_site/2009/03/27/hackers.html"

I think would be better written as

    And I have the following post:
      | title   | date      | content          |   
      | Hackers | 2009-03-27 | My First Exploit |

It's more international and explicit. Also don't really see any advantage to mm/dd/YYYY

@parkr
Copy link
Member

parkr commented May 24, 2013

Yeah I was confused by that choice initially as well. I'd be down to shift it to the new format - it'd also be more easily manipulated because it's valid input for Time.parse, so wouldn't have to do any of this strange format-picking business.

@mattr-
Copy link
Member

mattr- commented May 25, 2013

Yes please! ISO standard date format FTW! ✨

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants