-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cucumbers tests need to be more clear around timezones #1126
Comments
Doesn't your pull request that I just merged fix this? |
I meant this as a more generally then my pull request. For example: Scenario: Basic site with a post
Given I have a _posts directory
And I have the following post:
| title | date | content |
| Hackers | 3/27/2009 | My First Exploit |
When I run jekyll
Then the _site directory should exist
And I should see "My First Exploit" in "_site/2009/03/27/hackers.html" I think would be better written as And I have the following post:
| title | date | content |
| Hackers | 2009-03-27 | My First Exploit | It's more international and explicit. Also don't really see any advantage to mm/dd/YYYY |
Yeah I was confused by that choice initially as well. I'd be down to shift it to the new format - it'd also be more easily manipulated because it's valid input for |
Yes please! ISO standard date format FTW! ✨ |
The cucumbers tests need a clean up around time-zones. Some of the asserts are implicitly imply date times that would have different time-zones.
See #1090
The text was updated successfully, but these errors were encountered: