Bump safe_yaml to ~> 1.0.0 #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be more strict about what versions we'll take, since this is the stable branch
| @@ -29,7 +29,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency('maruku', "~> 0.7.0") | |||
| s.add_runtime_dependency('pygments.rb', "~> 0.5.0") | |||
| s.add_runtime_dependency('commander', "~> 4.1.3") | |||
| s.add_runtime_dependency('safe_yaml', "~> 0.9.7") | |||
| s.add_runtime_dependency('safe_yaml', "~> 1.0.0") | |||
There was a problem hiding this comment.
It's ~1.0 in master which will download a 1.1 once it's released. I didn't like that idea for a stable branch that's supposed to be relatively stable. So I locked it to 1.0.x. Do we want to let Jekyll 1.x float on safe_yaml 1.x?
There was a problem hiding this comment.
As long as 1.x has 1.8.7 support. 1.0.x is probably safer, so I'm 👍 with it as-is as long as the tests can be fixed.
There was a problem hiding this comment.
Ok. Might take a few more days. I have to dust off the VM with 1.8.7 on it.
ghost
assigned 
|
1.0.x has 1.8.7 support! Ready to ship this. |
parkr
added a commit
that referenced
this pull request
Jan 22, 2014
|
✨ ❤️ 🎉 |
parkr
added a commit
that referenced
this pull request
Jan 22, 2014
parkr
added a commit
that referenced
this pull request
Jan 22, 2014
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more strict about what versions we'll take, since this is the stable
branch.
This fixes #1792 for the 1.4.x series of releases.