Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBrick development server returns wrong charset on 404 #2289

Closed
sentience opened this issue May 3, 2014 · 2 comments
Closed

WEBrick development server returns wrong charset on 404 #2289

sentience opened this issue May 3, 2014 · 2 comments

Comments

@sentience
Copy link

With the Jekyll development server running, if you request a URL that does not exist, the server responds with the rendered contents of 404.html (correct), but with the wrong encoding specified in the Content-Type header:

$ wget http://localhost:4000/bad-url.html --content-on-error -S
--2014-05-03 16:32:24--  http://localhost:4000/bad-url.html
Resolving localhost... ::1, 127.0.0.1, fe80::1
Connecting to localhost|::1|:4000... failed: Connection refused.
Connecting to localhost|127.0.0.1|:4000... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 404 Not Found
  Content-Type: text/html; charset=ISO-8859-1
  Server: WEBrick/1.3.1 (Ruby/2.1.1/2014-02-24)
  Date: Sat, 03 May 2014 06:32:24 GMT
  Content-Length: 6727
  Connection: close
Saving to: 'bad-url.html'

100%[================================================================================================================================================>] 6,727       --.-K/s   in 0s

Note the Content-Type header says charset=ISO-8859-1 even though I am running Jekyll 2.0.0rc1, which is supposed to default to UTF-8 (and does so for all other pages).

@doktorbro
Copy link
Member

Same here with Jekyll 1.5.1:

Content-Type

text/html; charset=ISO-8859-1

Server

WEBrick/1.3.1 (Ruby/1.9.3/2011-10-30)

@parkr
Copy link
Member

parkr commented May 3, 2014

oh hey https://github.com/ruby/ruby/blob/trunk/lib/webrick/httpresponse.rb#L341

looks like a webrick issue

@parkr parkr closed this as completed in 3af22f1 May 3, 2014
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants