-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jekyll 3.0.0-beta1/Liquid 3 Issue with Handlebars highlighting #3557
Comments
Can you please try with beta2 and confirm it's still broken there so we can block the next beta? |
When I use the beta2 release I get the following Errors: Build Warning: Layout 'nil' requested in article.json does not exist.
Build Warning: Layout 'nil' requested in atom.xml does not exist.
Liquid Exception: Liquid syntax error: Expected end_of_string but found pipe in "post in site.posts | limit: 10" in _layouts/front-page.html So with this release it seems that limits are broken. The Error with Raw Tags and Handlebars Syntax are still present unfortunately. Affected file: https://github.com/kevingimbel/kevingimbel.github.io/blob/master/_layouts/front-page.html#L8 |
Can you please file a unique bug for that one and attach it to this ticket by ref-ing it. |
Is this fixed? |
Not that I know of, it still existed in beta2? If he doesn't respond I'll test and see tonight. |
Plot twist. This works: require 'liquid'
require "#{ENV['HOME']}/jekyll/jekyll/lib/jekyll.rb"
class SomeSite
def safe
true
end
def highlighter
'pygments'
end
end
content = <<-EOS
{% highlight html %}
{% raw %}
{{#post}}
<article class="post">
<hgroup>
<h2>{{{title}}}</h2>
{{#if author}}
written by {{author.name}}
{{/if}}
</hgroup>
</article>
{{/post}}
{% endraw %}
{% endhighlight %}
EOS
puts Liquid::Template.parse(content).render({}, { :registers => { :site => SomeSite.new } }) |
@chrisfinazzo Indeed, thanks! Your layout should be Looks like we fixed your other issue before in #3559. |
After upgrading to Jekyll 3.0.0-beta1 I get the following Liquid Error for one of my posts:
The specific part of the post is the following:
I used the
{% raw %}
tags here to prevent Jekyll/Liquid from parsing the Handelbars code snippet. Now with the latest version of either Liquid or Jekyll this seems to not work anymore and I can't build my site.I couldn't find a open issue or a temporary workaround for this. Any ideas how to prevent this?
Additional info:
Ruby Version: ruby 2.0.0p481 (2014-05-08 revision 45883) [x86_64-linux]
OS: Ubuntu 14.04
Jekyll: 3.0.0-beta1
Repo: https://github.com/kevingimbel/kevingimbel.github.io
Post with Issue: https://github.com/kevingimbel/kevingimbel.github.io/blob/master/_posts/2013-10-16-ghost-in-the-shell.md
The text was updated successfully, but these errors were encountered: