Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to less generic FormKeep page #4243

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Link to less generic FormKeep page #4243

merged 1 commit into from
Dec 9, 2015

Conversation

r00k
Copy link

@r00k r00k commented Dec 9, 2015

This link used to point to a generic landing page. Now it links to a guide written specifically for Jekyll users.

This link used to point to a generic landing page. Now it links to a guide written specifically for Jekyll users.
@parkr
Copy link
Member

parkr commented Dec 9, 2015

Thanks, @r00k. Seems useful.

parkr added a commit that referenced this pull request Dec 9, 2015
Merge pull request 4243
@parkr parkr merged commit be032c5 into jekyll:master Dec 9, 2015
parkr added a commit that referenced this pull request Dec 9, 2015
@envygeeks
Copy link
Contributor

Indeed, I didn't even know FormKeep existed until I seen this PR.

@r00k
Copy link
Author

r00k commented Dec 9, 2015

@envygeeks Glad you've heard of us now :). Happy to answer any questions you might have about the service (or to hear your feedback if you sign up).

r00k pushed a commit to r00k/jekyll that referenced this pull request Dec 9, 2015
jekyll#4243 updated this link to a jekyll-specific page. This commit adds utm params to the link so we can tell that users came to us from the Jekyll documentation. Among other things, this will help us provide better support to Jekyll users who sign up, since we'll know what site generator they're using.
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants