Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

disallow using source dir as destination dir #537

Closed
zpao opened this Issue Apr 11, 2012 · 5 comments

Comments

Projects
None yet
4 participants

zpao commented Apr 11, 2012

jekyll . has bitten me at least once and I doubt I'm the only one. It's salvageable unless you were ignoring files or hadn't pushed to a repo somewhere recently.

So I propose disallowing the use of src as dest. I can't think of anybody who would want to do that and if they do, then put a prompt layer or require the use of a flag.

@zpao, please ignore @svnpenn. Go ahead and use my fork of jekyll at https://github.com/jameskilton/jekyll which fixes these issues until my pull request mojombo#535 can be applied.

And I can't imagine how you are still incapable of understanding that people make mistakes.

zpao commented Apr 11, 2012

You wouldn't want to dump them into your git repo. That's the point - there is virtually no good reason to overwrite your source files.

It's not uncommon to run a command to operate on the current directory. And destructive commands often prevent you from fucking up. That's a basic UX principal. If you really wanted to do that destructive action, then --force is usually available.

@svnpenn, I don't see that you're a maintainer of this repo, so I don't understand why you would be so vehemently against a minimal change designed to protect users.

@jameskilton, I saw your pull request, thanks for beating me to the punch :)

zpao commented Apr 11, 2012

Jekyll does not generate dot files.

It does if you want it to. See 9d70088

Owner

parkr commented Dec 22, 2012

Closing in favour of #535.

@parkr parkr closed this Dec 22, 2012

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.