-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disallow using source dir as destination dir #537
Comments
@zpao, please ignore @svnpenn. Go ahead and use my fork of jekyll at https://github.com/jameskilton/jekyll which fixes these issues until my pull request #535 can be applied. |
And I can't imagine how you are still incapable of understanding that people make mistakes. |
You wouldn't want to dump them into your git repo. That's the point - there is virtually no good reason to overwrite your source files. It's not uncommon to run a command to operate on the current directory. And destructive commands often prevent you from fucking up. That's a basic UX principal. If you really wanted to do that destructive action, then @svnpenn, I don't see that you're a maintainer of this repo, so I don't understand why you would be so vehemently against a minimal change designed to protect users. @jameskilton, I saw your pull request, thanks for beating me to the punch :) |
It does if you want it to. See 9d70088 |
Closing in favour of #535. |
jekyll .
has bitten me at least once and I doubt I'm the only one. It's salvageable unless you were ignoring files or hadn't pushed to a repo somewhere recently.So I propose disallowing the use of
src
asdest
. I can't think of anybody who would want to do that and if they do, then put a prompt layer or require the use of a flag.The text was updated successfully, but these errors were encountered: