Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow using source dir as destination dir #537

Closed
zpao opened this issue Apr 11, 2012 · 5 comments
Closed

disallow using source dir as destination dir #537

zpao opened this issue Apr 11, 2012 · 5 comments

Comments

@zpao
Copy link

zpao commented Apr 11, 2012

jekyll . has bitten me at least once and I doubt I'm the only one. It's salvageable unless you were ignoring files or hadn't pushed to a repo somewhere recently.

So I propose disallowing the use of src as dest. I can't think of anybody who would want to do that and if they do, then put a prompt layer or require the use of a flag.

@jasonroelofs
Copy link

@zpao, please ignore @svnpenn. Go ahead and use my fork of jekyll at https://github.com/jameskilton/jekyll which fixes these issues until my pull request #535 can be applied.

@jasonroelofs
Copy link

And I can't imagine how you are still incapable of understanding that people make mistakes.

@zpao
Copy link
Author

zpao commented Apr 11, 2012

You wouldn't want to dump them into your git repo. That's the point - there is virtually no good reason to overwrite your source files.

It's not uncommon to run a command to operate on the current directory. And destructive commands often prevent you from fucking up. That's a basic UX principal. If you really wanted to do that destructive action, then --force is usually available.

@svnpenn, I don't see that you're a maintainer of this repo, so I don't understand why you would be so vehemently against a minimal change designed to protect users.

@jameskilton, I saw your pull request, thanks for beating me to the punch :)

@zpao
Copy link
Author

zpao commented Apr 11, 2012

Jekyll does not generate dot files.

It does if you want it to. See 9d70088

@parkr
Copy link
Member

parkr commented Dec 22, 2012

Closing in favour of #535.

@parkr parkr closed this as completed Dec 22, 2012
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants