Fix handling of non-ASCII characters in new *_url filters
#5410
Conversation
|
Punycode, you are the worst. Encoding URL's is notorious. I think this could be a fix for after 3.3 just because it's so gnarly. Does Ruby stdlib have anything for this? |
| @@ -38,4 +38,5 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency('jekyll-sass-converter', '~> 1.0') | |||
| s.add_runtime_dependency('jekyll-watch', '~> 1.1') | |||
| s.add_runtime_dependency("pathutil", "~> 0.9") | |||
| s.add_runtime_dependency('addressable', '~> 2.4') | |||
There was a problem hiding this comment.
Addressable was already being installed implicitly, so this is not actually adding a new dependency.
There was a problem hiding this comment.
Doesn't look like it's a dependency of jekyll, but it a dependency of jekyll-sitemap per a Gemfile.lock of mine using both. So it is technically not used yet.
Oh please no. I feel like plugins won't be able to rely on this filter until this is resolved.
I don't think so, and that's why Addressable exists. It was already an implicit dependency, so I don't see a problem using it here. |
|
Travis likes it! ✅ |
|
I'm OK with this. @jekyll/stability, any thoughts? |
parkr
changed the title
*_url filters
|
@jekyllbot: merge +bug |
How/where should normalization be handled? I would love if the filters could also be responsible for normalization.