Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Rubocop version #5496

Merged
merged 1 commit into from Oct 19, 2016
Merged

Restrict Rubocop version #5496

merged 1 commit into from Oct 19, 2016

Conversation

pathawks
Copy link
Member

Sometimes Rubocop will add cops in a minor version and all of a sudden CI starts breaking for reasons unrelated to any recent changes. This locks Rubocop to the current minor version so that we can start using new cops on our schedule 馃憤

/cc: @jekyll/core @ashmaroli

@parkr
Copy link
Member

parkr commented Oct 19, 2016

I don't mind that this happens, to some degree. It helps us stay current. Whenever we lock this, we end up just falling behind and it makes updates really painful because it's not just 1 or 2 cops added, it's like 38. That said, it hurts contributors who want a green CI and don't understand why it's failing.

I'll defer here.

@pathawks
Copy link
Member Author

pathawks commented Oct 19, 2016

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

@parkr
Copy link
Member

parkr commented Oct 19, 2016

@pathawks That's a good idea. jekyllbot is currently stateless but I bet this would be fruitful work. We could do this for other dependencies as well by checking RubyGems against our Gemfile and gemspec.

@ashmaroli
Copy link
Member

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

Love this idea..
Till date, JekyllBot needs explicit commands from the maintainers here to do something.. The only thing I found it does automatically is mark issues as stale and warn users that JekyllHelp is no longer functional..
JekyllBot opening a PR automatically would be so cool.. Hope it would also understand that we currently (as of then) do not intend to bump a dependency version..

@pathawks
Copy link
Member Author

@parkr
Copy link
Member

parkr commented Oct 19, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d979b4b into master Oct 19, 2016
@jekyllbot jekyllbot deleted the pr/rubocop branch October 19, 2016 19:10
jekyllbot added a commit that referenced this pull request Oct 19, 2016
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants