Restrict Rubocop version #5496

Merged
merged 1 commit into from Oct 19, 2016

Projects

None yet

4 participants

@pathawks
Member

Sometimes Rubocop will add cops in a minor version and all of a sudden CI starts breaking for reasons unrelated to any recent changes. This locks Rubocop to the current minor version so that we can start using new cops on our schedule 👍

/cc: @jekyll/core @ashmaroli

@pathawks pathawks Restrict Rubocop version
cc19728
@parkr
Member
parkr commented Oct 19, 2016

I don't mind that this happens, to some degree. It helps us stay current. Whenever we lock this, we end up just falling behind and it makes updates really painful because it's not just 1 or 2 cops added, it's like 38. That said, it hurts contributors who want a green CI and don't understand why it's failing.

I'll defer here.

@pathawks
Member
pathawks commented Oct 19, 2016 edited

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

@parkr
Member
parkr commented Oct 19, 2016

@pathawks That's a good idea. jekyllbot is currently stateless but I bet this would be fruitful work. We could do this for other dependencies as well by checking RubyGems against our Gemfile and gemspec.

@ashmaroli
Contributor

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

Love this idea..
Till date, JekyllBot needs explicit commands from the maintainers here to do something.. The only thing I found it does automatically is mark issues as stale and warn users that JekyllHelp is no longer functional..
JekyllBot opening a PR automatically would be so cool.. Hope it would also understand that we currently (as of then) do not intend to bump a dependency version..

@parkr
Member
parkr commented Oct 19, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d979b4b into master Oct 19, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jekyllbot jekyllbot deleted the pr/rubocop branch Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment