New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Rubocop version #5496

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented Oct 19, 2016

Sometimes Rubocop will add cops in a minor version and all of a sudden CI starts breaking for reasons unrelated to any recent changes. This locks Rubocop to the current minor version so that we can start using new cops on our schedule 馃憤

/cc: @jekyll/core @ashmaroli

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 19, 2016

Member

I don't mind that this happens, to some degree. It helps us stay current. Whenever we lock this, we end up just falling behind and it makes updates really painful because it's not just 1 or 2 cops added, it's like 38. That said, it hurts contributors who want a green CI and don't understand why it's failing.

I'll defer here.

Member

parkr commented Oct 19, 2016

I don't mind that this happens, to some degree. It helps us stay current. Whenever we lock this, we end up just falling behind and it makes updates really painful because it's not just 1 or 2 cops added, it's like 38. That said, it hurts contributors who want a green CI and don't understand why it's failing.

I'll defer here.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 19, 2016

Member

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

Member

pathawks commented Oct 19, 2016

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 19, 2016

Member

@pathawks That's a good idea. jekyllbot is currently stateless but I bet this would be fruitful work. We could do this for other dependencies as well by checking RubyGems against our Gemfile and gemspec.

Member

parkr commented Oct 19, 2016

@pathawks That's a good idea. jekyllbot is currently stateless but I bet this would be fruitful work. We could do this for other dependencies as well by checking RubyGems against our Gemfile and gemspec.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 19, 2016

Member

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

Love this idea..
Till date, JekyllBot needs explicit commands from the maintainers here to do something.. The only thing I found it does automatically is mark issues as stale and warn users that JekyllHelp is no longer functional..
JekyllBot opening a PR automatically would be so cool.. Hope it would also understand that we currently (as of then) do not intend to bump a dependency version..

Member

ashmaroli commented Oct 19, 2016

Is there any way @jekyllbot could open an issue/PR anytime this needs to be bumped? Subscribe to updates from Rubocop?

Love this idea..
Till date, JekyllBot needs explicit commands from the maintainers here to do something.. The only thing I found it does automatically is mark issues as stale and warn users that JekyllHelp is no longer functional..
JekyllBot opening a PR automatically would be so cool.. Hope it would also understand that we currently (as of then) do not intend to bump a dependency version..

@pathawks

This comment has been minimized.

Show comment
Hide comment
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 19, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Oct 19, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d979b4b into master Oct 19, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pr/rubocop branch Oct 19, 2016

jekyllbot added a commit that referenced this pull request Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment