Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use site.baseurl before link and post_url tags #5559

Merged
merged 2 commits into from Nov 10, 2016
Merged

Use site.baseurl before link and post_url tags #5559

merged 2 commits into from Nov 10, 2016

Conversation

ryandesign
Copy link
Contributor

This PR updates the documentation to show that {{ site.baseurl }} must be used before the {% link %} and {% post_url %} tags.

@DirtyF DirtyF self-assigned this Nov 8, 2016
pathawks
pathawks previously requested changes Nov 8, 2016
View reviewed changes
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use the new relative_url filter.

@ryandesign
Copy link
Contributor Author

Let's just use the new relative_url filter.

That's what I tried first. I couldn't get it to work. When I researched why, it seemed that filters can only be used with {{ ... }} notation, not with {% ... %} notation.

@parkr
Copy link
Member

parkr commented Nov 10, 2016

@pathawks We'd have to make sure link calls that filter explicitly. Want to submit a PR to that effect?

@parkr parkr closed this Nov 10, 2016
@pathawks
Copy link
Member

#5569

@pathawks
Copy link
Member

We'd have to make sure link calls that filter explicitly.

Since that'd be a breaking change, let's update the docs first 👍

@pathawks pathawks reopened this Nov 10, 2016
@pathawks pathawks dismissed their stale review November 10, 2016 21:54

Filters cannot be used inside tags

parkr
parkr approved these changes Nov 10, 2016
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Merge upon all-green.

@pathawks
Copy link
Member

Thank you @ryandesign 👍

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 810f0e9 into jekyll:master Nov 10, 2016
jekyllbot added a commit that referenced this pull request Nov 10, 2016
@jekyllbot
Update history to reflect merge of #5559 [ci skip]
262ebbb
@ryandesign ryandesign deleted the use-baseurl-before-link-tag branch November 11, 2016 05:06
@gkotian gkotian mentioned this pull request May 1, 2017
Closed
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

@pathawks pathawks pathawks approved these changes

Assignees

@DirtyF DirtyF

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ryandesign @parkr @pathawks @DirtyF @jekyllbot