New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use site.baseurl before link and post_url tags #5559

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Projects
None yet
5 participants
@ryandesign
Contributor

ryandesign commented Nov 8, 2016

This PR updates the documentation to show that {{ site.baseurl }} must be used before the {% link %} and {% post_url %} tags.

@DirtyF DirtyF added the documentation label Nov 8, 2016

@DirtyF DirtyF self-assigned this Nov 8, 2016

@pathawks

Let's just use the new relative_url filter.

@ryandesign

This comment has been minimized.

Show comment
Hide comment
@ryandesign

ryandesign Nov 8, 2016

Contributor

Let's just use the new relative_url filter.

That's what I tried first. I couldn't get it to work. When I researched why, it seemed that filters can only be used with {{ ... }} notation, not with {% ... %} notation.

Contributor

ryandesign commented Nov 8, 2016

Let's just use the new relative_url filter.

That's what I tried first. I couldn't get it to work. When I researched why, it seemed that filters can only be used with {{ ... }} notation, not with {% ... %} notation.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2016

Member

@pathawks We'd have to make sure link calls that filter explicitly. Want to submit a PR to that effect?

Member

parkr commented Nov 10, 2016

@pathawks We'd have to make sure link calls that filter explicitly. Want to submit a PR to that effect?

@parkr parkr closed this Nov 10, 2016

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks
Member

pathawks commented Nov 10, 2016

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 10, 2016

Member

We'd have to make sure link calls that filter explicitly.

Since that'd be a breaking change, let's update the docs first 👍

Member

pathawks commented Nov 10, 2016

We'd have to make sure link calls that filter explicitly.

Since that'd be a breaking change, let's update the docs first 👍

@pathawks pathawks reopened this Nov 10, 2016

Filters cannot be used inside tags

@parkr

parkr approved these changes Nov 10, 2016

👌 Merge upon all-green.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 10, 2016

Member

Thank you @ryandesign 👍

@jekyllbot: merge +site

Member

pathawks commented Nov 10, 2016

Thank you @ryandesign 👍

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 810f0e9 into jekyll:master Nov 10, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Nov 10, 2016

@ryandesign ryandesign deleted the ryandesign:use-baseurl-before-link-tag branch Nov 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment