Use site.baseurl before link and post_url tags #5559

Merged
merged 2 commits into from Nov 10, 2016

Projects

None yet

5 participants

@ryandesign
Contributor

This PR updates the documentation to show that {{ site.baseurl }} must be used before the {% link %} and {% post_url %} tags.

ryandesign added some commits Nov 8, 2016
@ryandesign ryandesign Use site.baseurl before link tag 70fae19
@ryandesign ryandesign Use site.baseurl before post_url tag
92354fa
@DirtyF DirtyF added the documentation label Nov 8, 2016
@DirtyF DirtyF self-assigned this Nov 8, 2016
@pathawks

Let's just use the new relative_url filter.

@ryandesign
Contributor

Let's just use the new relative_url filter.

That's what I tried first. I couldn't get it to work. When I researched why, it seemed that filters can only be used with {{ ... }} notation, not with {% ... %} notation.

@parkr
Member
parkr commented Nov 10, 2016

@pathawks We'd have to make sure link calls that filter explicitly. Want to submit a PR to that effect?

@parkr parkr closed this Nov 10, 2016
@pathawks
Member
@pathawks
Member

We'd have to make sure link calls that filter explicitly.

Since that'd be a breaking change, let's update the docs first 👍

@pathawks pathawks reopened this Nov 10, 2016
@pathawks pathawks dismissed their review Nov 10, 2016

Filters cannot be used inside tags

@parkr
parkr approved these changes Nov 10, 2016 View changes

👌 Merge upon all-green.

@pathawks
Member

Thank you @ryandesign 👍

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 810f0e9 into jekyll:master Nov 10, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryandesign ryandesign deleted the ryandesign:use-baseurl-before-link-tag branch Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment