Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw IncludeTagError if error occurs in included file #5767

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Crunch09
Copy link
Member

Hi,
at first i thought about using the new Liquid::Error#template_name field but it's only available in Liquid 4 and we already have Jekyll::Tags::IncludeTagError which wasn't used anywhere.

Before:
bildschirmfoto 2017-01-15 um 20 43 15

After:
bildschirmfoto 2017-01-15 um 20 43 43

fixes #5756

/cc @jekyll/build

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@parkr
Copy link
Member

parkr commented Jan 16, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 6c4699b into jekyll:master Jan 16, 2017
@parkr parkr added this to the 3.4 milestone Jan 16, 2017
jekyllbot added a commit that referenced this pull request Jan 16, 2017
@Crunch09 Crunch09 deleted the issue-5756 branch July 4, 2017 22:25
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liquid Exception not reported on original file
5 participants