Limit Posts Doesn't Support Drafts

[jhulst]

• I believe this to be a bug, not a question about using Jekyll.
• I updated to the latest Jekyll (or) if on GitHub Pages to the latest github-pages
• I read the CONTRIBUTION file at https://jekyllrb.com/docs/contributing/
• This is a feature request.

---

• I am on (or have tested on) macOS 10+
• I am on (or have tested on) Debian/Ubuntu GNU/Linux
• I am on (or have tested on) Fedora GNU/Linux
• I am on (or have tested on) Arch GNU/Linux
• I am on (or have tested on) Other GNU/Linux
• I am on (or have tested on) Windows 10+

---

• I was trying to install.
• There is a broken Plugin API.
• I had an error on GitHub Pages, and I have reproduced it locally.
• I had an error on GitHub Pages, and GitHub Support said it was a Jekyll Bug.
• I had an error on GitHub Pages and I did not test it locally.
• I was trying to build.
• It was another bug.

My Reproduction Steps

• Run build on project that has greater than 10 posts in _posts and a single post in _drafts
• Observe that the draft is built and shows in the blog listing page
• Add limit_posts: 10 option to configuration
• Run build
• Only the posts from _posts are built, the draft is not processed

The Output I Wanted

The draft posts should be built and included in the site output.

[pathawks]

So what is the expected behavior here? Should all drafts plus 10 non-drafts be built? Should 10 posts total be built, including up to 10 drafts?

[jhulst]

I would suggest that the date ordering that is done for drafts should take precedent rather than only showing the published posts. So if the 10 drafts would be the first 10 that are generated, then show those.

As is, it seems that drafts are categorically excluded which was very confusing and is not the behavior that would be helpful for people who are using limit_posts to speed up development builds (since they are probably most interested in drafts over published posts).

[parkr]

I agree that if --show-drafts is passed (or drafts: true), then limit_posts should take drafts + posts and limit the combination of the two.

Would you please submit a PR for this? Search the codebase for limit_posts and you should find the relevant code that trims the array. Thanks!

[tom-power]

Hi, when I pass --drafts and --limit-posts to build, drafts and posts are included? Added some tests here that are passing to show: master...tom-power:limit-posts-and-show-drafts

[epugh]

I saw that @parkr closed this issue, however, I believe the issue is still a valid issue and is just waiting for a PR!

[pathawks]

@epugh Yeah, if somebody submits a PR and mentions me, I would be happy to review 👍

[epugh]

So, is it as simple (maybe??) as swapping lines 65 and 66?

jekyll/lib/jekyll/reader.rb

Line 65 in 4271495

site.posts.docs.concat(post_reader.read_posts(dir))

Put the drafts in the front, and then if your limit is 10, but you have 20 drafts, you get the first 10. Andif your limit is 10, and you have 5 drafts and 10 published blogs, then you get the first 5 drafts and the first 5 posts???!

[pathawks]

@epugh That seems pretty straightforward. Care to open a PR where we can hash it out?

[epugh]

Sure. I’m going to see if I can grok the testing framework ;-)

…

On Oct 4, 2018, at 2:46 PM, Pat Hawks ***@***.***> wrote: @epugh <https://github.com/epugh> That seems pretty straightforward. Care to open a PR where we can hash it out? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5898 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABXe8I1PMGftzOFme4qDw9B4Qqc9GIZks5uhldogaJpZM4MIE9Z>.

_______________________ Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.

[epugh]

@pathawks so it turns out this is fixed in the latest Jekyll, and I am on 3.7.3. I tested out the unit tests that @tom-power wrote, and they passed. So added a PR...