Added direct collection access to future collection item feature test #6151
Conversation
|
@parkr It would have effectively made a duplicate of the test I modified. Since the scenario described matched the situation I was testing, I modified it. I can split it out into another test if you'd like. |
features/collections.feature
Outdated
| @@ -128,16 +128,18 @@ Feature: Collections | |||
| puppies: | |||
| output: false | |||
| """ | |||
| And I have a "foo.txt" file that contains "random static file" | |||
| And I have a "index.html" page that contains "Newest puppy: {% assign puppy = site.puppies.last %}{{ puppy.title }}" | |||
There was a problem hiding this comment.
I really thought site.puppies.first would be the newest.
There was a problem hiding this comment.
From my experience, apparently that is not the case. The documentation doesn't seem to specify.
… file output and Liquid access
|
Split this into a separate test as previously suggested. |
features/collections.feature
Outdated
| @@ -139,6 +139,28 @@ Feature: Collections | |||
| And the _site directory should exist | |||
| And the "_site/puppies/fido.html" file should not exist | |||
|
|
|||
| Scenario: Hidden collection with document with future date, accessed via Liquid | |||
There was a problem hiding this comment.
This is nitpicky, but could you change this to Hidden collection has document with future date, accessed via Liquid
I had trouble parsing the scenario description until I read the full test.
There was a problem hiding this comment.
Sure, no problem. I was just keeping with the phrasing on the prior test. That'll be fixed in just a sec.
|
Thanks! Appreciate you adding this test! 👍 |
|
@jekyllbot: merge +dev |
|
@mattr- I believe this is a failing test showing a behavior that isn’t working right. I see master as currently failing cucumber now on all ruby versions. Would you mind sending a patch to fix master and retry this patch with the proper fix to make the test pass? |
|
Oh! My bad! Why did I think this was passing earlier? 😞 Yup! I'll get right on fixing it. |
Further tests #5953
/cc @jekyll/build