Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cucumber feature to test link tag #6777

Merged
merged 1 commit into from Feb 17, 2018

Conversation

ashmaroli
Copy link
Member

Mainly to act as a control element for #6727 which passes other existing tests in spite of containing a breaking change.

@ashmaroli ashmaroli requested review from pathawks and a user February 15, 2018 12:01
@@ -36,7 +36,7 @@
Given(%r!^I have an? "(.*)" page(?: with (.*) "(.*)")? that contains "(.*)"$!) do |file, key, value, text|
File.write(file, Jekyll::Utils.strip_heredoc(<<-DATA))
---
#{key || "layout"}: #{value || "nil"}
#{key || "layout"}: #{value || "none"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep totally unrelated.. thought I'd fix this silently..

@ashmaroli ashmaroli mentioned this pull request Feb 17, 2018
13 tasks
@DirtyF
Copy link
Member

DirtyF commented Feb 17, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 275a1f4 into jekyll:master Feb 17, 2018
jekyllbot added a commit that referenced this pull request Feb 17, 2018
@ashmaroli ashmaroli deleted the link-tag-feature branch October 22, 2018 07:20
@jekyll jekyll locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants