New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate relative_url
filter in link
tag
#6727
Conversation
I like this. |
Yes, hence the big red label 😉 |
No, I agree that it should be a clean break. I wonder about an automated migration assistant. 🤔 |
|
At least breaking changes should be displayed in the post-install message. |
relative_url
filter in link
tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @DirtyF here, let's keep this in mind.
@ashmaroli of course we'll link to our migration guide. It's just that links are so common that it's the number one thing that's gonna break user's websites, people should know about this, even before considering migrating. |
@ashmaroli Let's merge this! Could you add a short post-install message? |
This comment has been minimized.
This comment has been minimized.
@jekyllbot: merge +major |
Resolves #5682
Closes #5943
With this,
{% link about.md %}
will return/blog/about/
for a site configured withbaseurl: /blog
andpermalink: pretty
BREAKING-CHANGE
Unit test/Cucumber featureDocumentation