Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate relative_url filter in link tag #6727

Merged
merged 6 commits into from Nov 4, 2018

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Jan 30, 2018

Resolves #5682
Closes #5943

With this, {% link about.md %} will return /blog/about/ for a site configured with
baseurl: /blog and permalink: pretty

BREAKING-CHANGE

  • Initial implementation
  • Unit test/ Cucumber feature
    Documentation

@ashmaroli ashmaroli added the breaking-change Affect current behavior label Jan 30, 2018
@ashmaroli ashmaroli added this to the 4.0 milestone Jan 30, 2018
@pathawks
Copy link
Member

I like this.
This could break just about every site that uses Jekyll.

@ashmaroli
Copy link
Member Author

This could break just about every site that uses Jekyll.

Yes, hence the big red label 😉
Alternatively, we can release this as a new tag entirely..

@pathawks
Copy link
Member

Alternatively, we can release this as a new tag entirely..

No, I agree that it should be a clean break.

I wonder about an automated migration assistant. 🤔

@ashmaroli
Copy link
Member Author

I wonder about an automated migration assistant.

Jekyll::Doctor would like to hire an intern to help.. 😁

@ghost ghost added this to Ideas/Unconfirmed in Jekyll 4.1 Feb 11, 2018
@DirtyF DirtyF requested a review from a team March 30, 2018 19:43
@DirtyF
Copy link
Member

DirtyF commented Mar 30, 2018

At least breaking changes should be displayed in the post-install message.

@DirtyF DirtyF requested review from a team May 7, 2018 07:25
@DirtyF DirtyF moved this from Ideas/Unconfirmed to Reviewable in Jekyll 4.1 May 7, 2018
@ashmaroli ashmaroli changed the title WIP: Incorporate relative_url filter in link tag Incorporate relative_url filter in link tag May 7, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @DirtyF here, let's keep this in mind.

@ashmaroli
Copy link
Member Author

@DirtyF @oe Why not just print the link to our Migration docs since there are going to be numerous breaking-changes..?

@DirtyF
Copy link
Member

DirtyF commented May 7, 2018

@ashmaroli of course we'll link to our migration guide. It's just that links are so common that it's the number one thing that's gonna break user's websites, people should know about this, even before considering migrating.

@ghost
Copy link

ghost commented Nov 4, 2018

@ashmaroli Let's merge this! Could you add a short post-install message?

@DirtyF

This comment has been minimized.

@DirtyF
Copy link
Member

DirtyF commented Nov 4, 2018

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit d926ebf into jekyll:master Nov 4, 2018
jekyllbot added a commit that referenced this pull request Nov 4, 2018
@ashmaroli ashmaroli deleted the url-filters-link-tag branch November 4, 2018 19:07
@ashmaroli ashmaroli moved this from Reviewable to Done in Jekyll 4.1 Dec 26, 2018
@jekyll jekyll locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Jekyll 4.1
  
Done
Development

Successfully merging this pull request may close these issues.

Allow filters on link tag link tag should use URL filters
4 participants