New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate `relative_url` filter in `link` tag #6727

Merged
merged 6 commits into from Nov 4, 2018

Conversation

5 participants
@ashmaroli
Member

ashmaroli commented Jan 30, 2018

Resolves #5682
Closes #5943

With this, {% link about.md %} will return /blog/about/ for a site configured with
baseurl: /blog and permalink: pretty

BREAKING-CHANGE

  • Initial implementation
  • Unit test/ Cucumber feature
    Documentation

@ashmaroli ashmaroli added this to the 4.0 milestone Jan 30, 2018

@pathawks

This comment has been minimized.

Member

pathawks commented Jan 30, 2018

I like this.
This could break just about every site that uses Jekyll.

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 30, 2018

This could break just about every site that uses Jekyll.

Yes, hence the big red label 😉
Alternatively, we can release this as a new tag entirely..

@pathawks

This comment has been minimized.

Member

pathawks commented Jan 30, 2018

Alternatively, we can release this as a new tag entirely..

No, I agree that it should be a clean break.

I wonder about an automated migration assistant. 🤔

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 30, 2018

I wonder about an automated migration assistant.

Jekyll::Doctor would like to hire an intern to help.. 😁

@oe oe added this to Ideas/Unconfirmed in Jekyll 4.0 Feb 11, 2018

@DirtyF DirtyF requested a review from jekyll/core Mar 30, 2018

@DirtyF

DirtyF approved these changes Mar 30, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Mar 30, 2018

At least breaking changes should be displayed in the post-install message.

@DirtyF DirtyF requested review from jekyll/build May 7, 2018

@DirtyF DirtyF moved this from Ideas/Unconfirmed to Reviewable in Jekyll 4.0 May 7, 2018

@ashmaroli ashmaroli changed the title from WIP: Incorporate relative_url filter in link tag to Incorporate `relative_url` filter in `link` tag May 7, 2018

@oe

oe approved these changes May 7, 2018

I agree with @DirtyF here, let's keep this in mind.

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented May 7, 2018

@DirtyF @oe Why not just print the link to our Migration docs since there are going to be numerous breaking-changes..?

@DirtyF

This comment has been minimized.

Member

DirtyF commented May 7, 2018

@ashmaroli of course we'll link to our migration guide. It's just that links are so common that it's the number one thing that's gonna break user's websites, people should know about this, even before considering migrating.

@oe

This comment has been minimized.

Member

oe commented Nov 4, 2018

@ashmaroli Let's merge this! Could you add a short post-install message?

@DirtyF

This comment was marked as outdated.

Member

DirtyF commented Nov 4, 2018

what about post_url?

@DirtyF

This comment has been minimized.

Member

DirtyF commented Nov 4, 2018

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit d926ebf into jekyll:master Nov 4, 2018

4 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added the feature label Nov 4, 2018

@ashmaroli ashmaroli deleted the ashmaroli:url-filters-link-tag branch Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment