Memoize Site#site_data
#6809
Merged
Memoize Site#site_data
#6809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
reviewed
Feb 27, 2018
lib/jekyll/site.rb
Outdated
| @@ -253,7 +253,7 @@ def categories | |||
| # | |||
| # Returns the Hash to be hooked to site.data. | |||
| def site_data | |||
| config["data"] || data | |||
| @site_data ||= config["data"] || data | |||
There was a problem hiding this comment.
If you want to memoize the ||, then it'd be: @site_data ||= (config["data"] || data). By default, this is equivalent to (@site_data ||= config["data"]) || data.
There was a problem hiding this comment.
This @site_data should also be reset in reset!
There was a problem hiding this comment.
Regarding the use of parenthesis, I did not know, this would be interpreted that way.. Thanks!
There was a problem hiding this comment.
@ashmaroli You might enjoy http://tmm1.net/ruby21-profiling/ which has an example of where parentheses went awry!
There was a problem hiding this comment.
Thanks. I'll check it out 😃
DirtyF
approved these changes
Feb 27, 2018
parkr
approved these changes
Feb 27, 2018
|
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Site#site_datais called twice per page / document when the popular pluginjekyll-seo-tagis usedjekyll-seo-tagis loaded by default via recent releases of Minima