Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache computed item property #7301

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Cache computed item property #7301

merged 1 commit into from
Mar 15, 2019

Conversation

ashmaroli
Copy link
Member

Summary

Cache output of private method Jekyll::Filters#item_property

Context

The official Documentation site at docs uses this method heavily via the where and sort Liquid Filters.

@ashmaroli
Copy link
Member Author

@DirtyF Will you be able to test this branch locally on your macOS with our docs site..?
Thanks in advance.. 😉

@DirtyF
Copy link
Member

DirtyF commented Oct 7, 2018

ref initial build time cached build
master 10.83s 7.48s
#7301 9.72s 6.23s

@DirtyF DirtyF requested a review from a team October 28, 2018 05:09
@DirtyF
Copy link
Member

DirtyF commented Mar 15, 2019

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 3b4151b into jekyll:master Mar 15, 2019
jekyllbot added a commit that referenced this pull request Mar 15, 2019
@jekyllbot
Update history to reflect merge of #7301 [ci skip]
3c231a4
@ashmaroli ashmaroli deleted the cache-computed-item-property branch March 15, 2019 17:15
@jekyll jekyll locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age optimization ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmaroli @DirtyF @jekyllbot