Add tests for New command #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| args_joined = args.join(" ") | ||
|
|
||
| if args_joined.empty? | ||
| puts "You must provide a path." |
There was a problem hiding this comment.
This should raise an error or otherwise terminate the process and return an exit code other than 0.
There was a problem hiding this comment.
I'd do something like
arg_string = args.join(" ")
raise ArgumentError, "You must specify a path." if arg_string.empty?
install_path = File.expand_path(arg_string, Dir.pwd)
...There was a problem hiding this comment.
That looks good to me. I wasn't sure on whether raising an exception was desired behaviour - I'll update it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote some tests around the New command.
Fixed an issue where FileUtils.cp_r was copying all files in sub-directories into the new directory, rather than preserving directory structure. Changed it to just make a copy of the site template directory then delete the sample post.