Fix random test failures in TestExcerpt #to_liquid #8884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
Failures can occur in the
TestExcerpt
#to_liquid
test when the random seed ordersTestFilters
tests beforeTestExcerpt
and the tests are run with a system time zone that's has a non-zero offset on 2013-07-22.The
TestFilters
setup changesENV["TZ"]
to"UTC"
but doesn't reset it.The
TestExcerpt
#to_liquid
test fails because@excerpt.to_liquid["date"]
returns a UTC time andTime.parse("2013-07-22")
returns a time in the system time zone:This pull request adds a teardown to
TestFilters
to resetENV["TZ"]
.