Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vendor folder by default #1416

Closed
wants to merge 1 commit into from
Closed

Exclude vendor folder by default #1416

wants to merge 1 commit into from

Conversation

benbalter
Copy link
Contributor

Travis CI recently changed the way it vendors gems (with the --development flag), which causes the default build to fail due to conflicts with Jekyll core living in ./vendor/, and thus being processed by Jekyll. Have to imagine putting Gems in vendor is a pretty standard practice, and is only going to become more common place as Jekyll popularity and maturity continues to evolve. (example)

screen shot 2013-08-13 at 8 59 42 am

In the vein of sane defaults, and the implied promise that things should Work Out of the Box ™️, let's just add vendor to the exclude list. Alternatively, or in addition, giving that templematic post a real date, or prefixing some folders with _ may also work, although be less ideal.

@parkr
Copy link
Member

parkr commented Aug 13, 2013

This is great! Only question is what happens if my site contains a vendor folder on purpose? How do we communicate this new default?

@benbalter
Copy link
Contributor Author

@parkr RULE WITH AN IRON FIST. NO MERCY.

Nah. Was thinking the same thing after I posted. Perhaps minimized the chances by being more explicit? gem/ruby or gen/bundle or whatever the sub folder(s) normally are?

@parkr
Copy link
Member

parkr commented Aug 13, 2013

Is this if you do bundle install --standalone?

@benbalter
Copy link
Contributor Author

or --deployment or --path /vendor/gems

@parkr
Copy link
Member

parkr commented Aug 13, 2013

Would you mind adding a feature test for this to ignore the vendor/gems or whatever? :)

@mattr-
Copy link
Member

mattr- commented Aug 14, 2013

🤘 👍 🆒

@routelastresort
Copy link

Noticed this with Travis, but also heroku: http://markcampbell.me/jekyll/heroku/2013/05/18/how-to-set-up-jekyll-on-heroku.html 👍

@parkr
Copy link
Member

parkr commented Nov 7, 2013

We could also add this to our docs somewhere?

@parkr
Copy link
Member

parkr commented Dec 14, 2013

Still interested in seeing this happen?

@parkr
Copy link
Member

parkr commented Dec 26, 2013

#1847 points us in the right direction for clearing up this mess.

At any rate, will close this as mojombo:master no longer exists.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants