-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude vendor folder by default #1416
Conversation
This is great! Only question is what happens if my site contains a |
@parkr RULE WITH AN IRON FIST. NO MERCY. Nah. Was thinking the same thing after I posted. Perhaps minimized the chances by being more explicit? |
Is this if you do |
or |
Would you mind adding a feature test for this to ignore the vendor/gems or whatever? :) |
🤘 👍 🆒 |
Noticed this with Travis, but also heroku: http://markcampbell.me/jekyll/heroku/2013/05/18/how-to-set-up-jekyll-on-heroku.html 👍 |
We could also add this to our docs somewhere? |
Still interested in seeing this happen? |
#1847 points us in the right direction for clearing up this mess. At any rate, will close this as |
Travis CI recently changed the way it vendors gems (with the
--development
flag), which causes the default build to fail due to conflicts with Jekyll core living in./vendor/
, and thus being processed by Jekyll. Have to imagine putting Gems invendor
is a pretty standard practice, and is only going to become more common place as Jekyll popularity and maturity continues to evolve. (example)In the vein of sane defaults, and the implied promise that things should Work Out of the Box ™️, let's just add
vendor
to the exclude list. Alternatively, or in addition, giving that templematic post a real date, or prefixing some folders with_
may also work, although be less ideal.