Update redcarpet to 2.3.0 #1515

Merged
merged 1 commit into from Sep 10, 2013

Projects

None yet

7 participants

@drewish
Contributor
drewish commented Sep 7, 2013

2.3 has fixed a few things (the smart single quote but it still has support Ruby 1.8.x.

@parkr
Member
parkr commented Sep 9, 2013

👍

@kelvinst
kelvinst commented Sep 9, 2013

I like it!

@mattr-
Member
mattr- commented Sep 10, 2013

As one of the maintainers of Redcarpet, I approve this message 😃
👍 :shipit:

@parkr parkr merged commit 9422fe6 into jekyll:master Sep 10, 2013

1 check passed

default The Travis CI build passed
Details
@parkr parkr added a commit that referenced this pull request Sep 10, 2013
@parkr parkr Update history to reflect merge of #1515 70d9225
@muan
muan commented Sep 29, 2013

👋 I just noticed this issue and tried using Jekyll from head, but the single quotes are still not being converted with redcarpet being 2.3.0. I wonder if it might be just me, had anyone confirmed that this does fix the single quotes?

@Technika

(y)

@parkr
Member
parkr commented Sep 29, 2013

@muan Not sure why that'd be happening for you. @mattr- would know more.

@drewish
Contributor
drewish commented Sep 29, 2013

@maun it definitely fixed it for me. You sure you're using red carpet for markdown and have smart quotes enabled in the config?

markdown:      redcarpet
redcarpet:
  extensions: [smart]
@muan
muan commented Sep 29, 2013

Thanks all. Turns out there was something wrong with which the version of the gem I was using, nothing wrong with this at all. Sorryyy. 🙏

@mattr-
Member
mattr- commented Oct 1, 2013

Glad you got it working!

@maun
maun commented Oct 1, 2013

Glad you got it working!

Reply to this email directly or view it on GitHub
#1515 (comment).

You guys are CC-ing the wrong person ;)
https://github.com/muan and not https://github.com/maun
https://github.com/muan

@muan muan added a commit to muan/scribble that referenced this pull request Nov 20, 2013
@muan muan Use redcarpet, see jekyll/jekyll#1515 ce28b24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment