New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redcarpet to 2.3.0 #1515

Merged
merged 1 commit into from Sep 10, 2013

Conversation

Projects
None yet
7 participants
@drewish
Contributor

drewish commented Sep 7, 2013

2.3 has fixed a few things (the smart single quote but it still has support Ruby 1.8.x.

@parkr

This comment has been minimized.

Member

parkr commented Sep 9, 2013

👍

@kelvinst

This comment has been minimized.

kelvinst commented Sep 9, 2013

I like it!

@mattr-

This comment has been minimized.

Member

mattr- commented Sep 10, 2013

As one of the maintainers of Redcarpet, I approve this message 😃
👍 :shipit:

parkr added a commit that referenced this pull request Sep 10, 2013

@parkr parkr merged commit 9422fe6 into jekyll:master Sep 10, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 10, 2013

@muan

This comment has been minimized.

muan commented Sep 29, 2013

👋 I just noticed this issue and tried using Jekyll from head, but the single quotes are still not being converted with redcarpet being 2.3.0. I wonder if it might be just me, had anyone confirmed that this does fix the single quotes?

@Technika

This comment has been minimized.

Technika commented Sep 29, 2013

(y)

@parkr

This comment has been minimized.

Member

parkr commented Sep 29, 2013

@muan Not sure why that'd be happening for you. @mattr- would know more.

@drewish

This comment has been minimized.

Contributor

drewish commented Sep 29, 2013

@maun it definitely fixed it for me. You sure you're using red carpet for markdown and have smart quotes enabled in the config?

markdown:      redcarpet
redcarpet:
  extensions: [smart]
@muan

This comment has been minimized.

muan commented Sep 29, 2013

Thanks all. Turns out there was something wrong with which the version of the gem I was using, nothing wrong with this at all. Sorryyy. 🙏

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 1, 2013

Glad you got it working!

@ghost

This comment has been minimized.

ghost commented Oct 1, 2013

Glad you got it working!

Reply to this email directly or view it on GitHub
#1515 (comment).

You guys are CC-ing the wrong person ;)
https://github.com/muan and not https://github.com/maun
https://github.com/muan

muan added a commit to muan/scribble that referenced this pull request Nov 20, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.