-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Support for Ruby v1.8.7 #1780
Conversation
Regarding the newer hash syntax, are we supposed to be following GitHub's Ruby styleguide? I only ask because it says to use hash rockets over the newer syntax. |
@mattr- Yeah, I don't really care about the way we write hashes. But I'm excited to get rid of this code! |
❤️❤️❤️ |
😍 |
👍 |
Please keep in mind that the latest Ubuntu LTS is shipped with Ruby v1.8.7. ruby -v
ruby 1.8.7 (2011-06-30 patchlevel 352) [i686-linux] Next Ubuntu LTS with newer Ruby will be released in April 2014. |
So is the latest version of CentOS. I don’t care what the distributions do. If they want to ship unsupported Rubies, then they can maintain older versions of the gem. |
I totally agree with @mattr-
|
@penibelst Noted! With tools like rbenv, rvm, chruby, etc, it should be relatively easy to move to a newer version of Ruby on those systems. I use rbenv on CentOS 6 and it's working just fine. :) @mattr- Any other notes? I think I found everything in the codebase that was a 1.8 work-around. Good to merge. |
ssshhhhhiiiiiippppppppp iiiiiiiiiitttttttttt!
|
yeeeehaw!!! 💥 ❤️ 😍 🐮 |
@mattr- Will Jekyll 2 use Redcarpet version 3? |
@penibelst I sure hope so! |
@parkr This sounds really interesting. Now I understand why you are so euphoric. It’s time for me to update my Ubuntu. |
For the record, removing Ruby 1.8 on Ubuntu 12.04 was very easy. Now I have
I took me only 5 minutes. |
-- Jekyll removed support for Ruby v1.8.7. See jekyll/jekyll#1780
Ruby 1.8.7 is dead.
We can start pressing forward with better hash syntax
and newer libraries which only support 1.9 and greater. Yay for The Future! (tm)