New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Support for Ruby v1.8.7 #1780

Merged
merged 8 commits into from Dec 11, 2013

Conversation

Projects
None yet
6 participants
@parkr
Member

parkr commented Dec 6, 2013

Ruby 1.8.7 is dead.

We can start pressing forward with better hash syntax
and newer libraries which only support 1.9 and greater. Yay for The Future! (tm)

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 7, 2013

Regarding the newer hash syntax, are we supposed to be following GitHub's Ruby styleguide? I only ask because it says to use hash rockets over the newer syntax.

@parkr

This comment has been minimized.

Member

parkr commented Dec 8, 2013

@mattr- Yeah, I don't really care about the way we write hashes. But I'm excited to get rid of this code!

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 9, 2013

❤️❤️❤️ :shipit:

@kelvinst

This comment has been minimized.

kelvinst commented Dec 9, 2013

😍

@cs

This comment has been minimized.

Contributor

cs commented Dec 9, 2013

👍

@doktorbro

This comment has been minimized.

Member

doktorbro commented Dec 10, 2013

Please keep in mind that the latest Ubuntu LTS is shipped with Ruby v1.8.7.

ruby -v
ruby 1.8.7 (2011-06-30 patchlevel 352) [i686-linux]

Next Ubuntu LTS with newer Ruby will be released in April 2014.

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 10, 2013

So is the latest version of CentOS. 

I don’t care what the distributions do. If they want to ship unsupported Rubies, then they can maintain older versions of the gem.

@kelvinst

This comment has been minimized.

kelvinst commented Dec 10, 2013

I totally agree with @mattr-

So is the latest version of CentOS.

I don’t care what the distributions do. If they want to ship unsupported
Rubies, then they can maintain older versions of the gem.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1780#issuecomment-30229390
.

@parkr

This comment has been minimized.

Member

parkr commented Dec 10, 2013

@penibelst Noted! With tools like rbenv, rvm, chruby, etc, it should be relatively easy to move to a newer version of Ruby on those systems. I use rbenv on CentOS 6 and it's working just fine. :)

@mattr- Any other notes? I think I found everything in the codebase that was a 1.8 work-around. Good to merge.

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 11, 2013

ssshhhhhiiiiiippppppppp iiiiiiiiiitttttttttt!

:shipit: 😃 ❤️ 🎉 💥 etc etc.

@kelvinst

This comment has been minimized.

kelvinst commented Dec 11, 2013

yeeeehaw!!! 💥 ❤️ 😍 🐮

mattr- added a commit that referenced this pull request Dec 11, 2013

@mattr- mattr- merged commit 39b6fe7 into master Dec 11, 2013

mattr- added a commit that referenced this pull request Dec 11, 2013

@parkr parkr deleted the kill-1-8 branch Dec 11, 2013

@doktorbro

This comment has been minimized.

Member

doktorbro commented Dec 11, 2013

@mattr- Will Jekyll 2 use Redcarpet version 3?

@parkr

This comment has been minimized.

Member

parkr commented Dec 11, 2013

@penibelst I sure hope so!

@doktorbro

This comment has been minimized.

Member

doktorbro commented Dec 11, 2013

@parkr This sounds really interesting. Now I understand why you are so euphoric. It’s time for me to update my Ubuntu.

@doktorbro

This comment has been minimized.

Member

doktorbro commented Dec 14, 2013

For the record, removing Ruby 1.8 on Ubuntu 12.04 was very easy. Now I have

ruby 1.9.3p0 (2011-10-30 revision 33570) [i686-linux]

I took me only 5 minutes.

gnusosa added a commit to gnusosa/jekyll-org that referenced this pull request May 28, 2014

Removing read_with_options based on upstream jekyll
-- Jekyll removed support for Ruby v1.8.7.
   See jekyll/jekyll#1780

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.