Maruku fenced code blocks #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # allow fenced code blocks (new in Maruku 0.7.0) | ||
| if @config['maruku']['fenced_code_blocks'] | ||
| MaRuKu::Globals[:fenced_code_blocks] = true |
There was a problem hiding this comment.
Why not just set the value of the config to the the value of the Globals? i.e.
MaRuKu::Globals[:fenced_code_blocks] = !!@config['maruku']['fenced_code_blocks']There was a problem hiding this comment.
All right, Captain Picky, I've updated the PR with your suggestion
|
LGTM! @mattr-? |
mattr-
added a commit
that referenced
this pull request
Dec 11, 2013
mattr-
added a commit
that referenced
this pull request
Dec 11, 2013
parkr
added a commit
that referenced
this pull request
Dec 15, 2013
|
Maruku 0.7.1 has been released, which includes @konklone's patch as well as several other bugfixes. See https://github.com/bhollis/maruku/blob/master/CHANGELOG.md for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
fenced_code_blocksoption in Maruku, and adds a test that verifies that it works.Note: This test accommodates for the newlines that Maruku 0.7.0 currently puts around the internals of
<code>blocks generated byfenced_code_blocks. If my PR fixing this at bhollis/maruku#112 is merged in, and Maruku's version is bumped, I'll follow up with another PR that bumps Jekyll's Maruku version to it, and removes the newlines from this test.